Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

homeassistant: Migrate to ujson & numpy using pip #5096

Merged
merged 9 commits into from
Jan 25, 2022
Merged

homeassistant: Migrate to ujson & numpy using pip #5096

merged 9 commits into from
Jan 25, 2022

Conversation

th0ma7
Copy link
Contributor

@th0ma7 th0ma7 commented Jan 23, 2022 •
edited
Loading

Description

Pursuing work on migrating all python dependencies to regular pip building. In this specific case trying to solve two issues:

  1. ujson which in turns requires setuptools-scm to be added to the crossenv. Hint provided by upstream through Could not find a version that satisfies the requirement ujson==5.1.0 ultrajson/ultrajson#496
  2. numpy to standardize it using pip build process instead of cross/numpy. Note that ARMv5 still require code fix BUG: Allow using -std=c++0x on older compilers numpy/numpy#20664 but support for such old compiler is expected to end real soon.

Checklist

  • Build rule all-supported completed successfully
  • New installation of package completed successfully
  • Package upgrade completed successfully (Manually install the package again)
  • Package functionality was tested
  • Any needed documentation is updated/created

Type of change

  • Bug fix
  • New Package
  • Package update
  • Includes small framework changes
  • This change requires a documentation update (e.g. Wiki)

@th0ma7 th0ma7 self-assigned this Jan 23, 2022
@th0ma7
Copy link
Contributor Author

th0ma7 commented Jan 24, 2022 •
edited
Loading

@SynoCommunity/developers comcerto2k error on bazarr, does this ring any bell to any of you?

Found hints of where the issue is: wheels build flags not being passed post include ../../mk/spksrc.common.mk. Currently investigating.

EDIT: It ends-up a few DSM-7 archs still uses gcc 4.x resulting in a need to handle -std=c++0x using TC_GCC variable.

@th0ma7 th0ma7 mentioned this pull request Jan 25, 2022
Merged
10 tasks
@th0ma7 th0ma7 changed the title [WIP] homeassistant: Migrate ujson to using pip through setuptools-scm [WIP] homeassistant: Migrate to ujson & numpy using pip Jan 25, 2022
@th0ma7 th0ma7 mentioned this pull request Jan 25, 2022
Closed
10 tasks
@th0ma7 th0ma7 requested a review from hgy59 January 25, 2022 02:13
@Safihre
Copy link
Contributor

Safihre commented Jan 25, 2022

Maybe also patch Python to 3.10.2? It was a Hotfix because of a memory leak.

@th0ma7
Copy link
Contributor Author

th0ma7 commented Jan 25, 2022

That will be part of another PR as I want to limit the scope of this one.

@th0ma7 th0ma7 changed the title [WIP] homeassistant: Migrate to ujson & numpy using pip homeassistant: Migrate to ujson & numpy using pip Jan 25, 2022
@th0ma7 th0ma7 merged commit 4dc6b1a into SynoCommunity:master Jan 25, 2022
@th0ma7 th0ma7 deleted the ujson branch January 25, 2022 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hgy59 hgy59 Awaiting requested review from hgy59

Assignees

@th0ma7 th0ma7

Labels
status/needs-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: Allow using -std=c++0x on older compilers
2 participants
@th0ma7 @Safihre